Skip to content

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Feb 5, 2025

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Move to the new isolated and warm up bench system

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-6720-multibench branch 4 times, most recently from 6b7cb2c to d24a4d4 Compare February 6, 2025 14:54
@nbbeeken nbbeeken marked this pull request as ready for review February 6, 2025 14:57
@nbbeeken nbbeeken requested a review from a team as a code owner February 6, 2025 14:58
Base automatically changed from NODE-6705-isolate-benches to main February 6, 2025 16:42
@nbbeeken nbbeeken force-pushed the NODE-6720-multibench branch 2 times, most recently from 415aa0f to 827266c Compare February 6, 2025 16:50
@baileympearson baileympearson self-assigned this Feb 6, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 6, 2025
@nbbeeken nbbeeken force-pushed the NODE-6720-multibench branch from 827266c to ff73b41 Compare February 6, 2025 18:09
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor changes

@baileympearson baileympearson merged commit 198fb72 into main Feb 6, 2025
25 of 30 checks passed
@baileympearson baileympearson deleted the NODE-6720-multibench branch February 6, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants